feat(gnovm): enforce size of int and uint to 64 bits on all arch. #3591
Conversation
With these changes, `int` and `uint` are always represented in gnovm as `int64` and `uint64` whatever the underlying hardware architecture. There should be no change for 64 bits platforms. On other (unsupported) platforms, `int` and `uint` will be 64 bits instead of hardware size. Fixes gnolang#3288.
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
| l := big.NewInt(int64(lv.GetInt())) | ||
| r := big.NewInt(0).Lsh(l, rv.GetUint()) | ||
| l := big.NewInt(lv.GetInt()) | ||
| r := big.NewInt(0).Lsh(l, uint(rv.GetUint())) |
There was a problem hiding this comment.
I think for these cases, where we don't work on Bigint types, it may be useful to just use min(rv.GetUint(), 64), as all operations beyond 64 behave the same and would return 0 anyway.
There was a problem hiding this comment.
We probably should have a different implementation of operators, one for the general var case, fast and not relying on bigints, and the other for constants, slower using bigints. This is a deep change, not for this PR.
| @@ -91,15 +91,15 @@ func (m *Machine) doOpSlice() { | |||
| var lowVal, highVal, maxVal int = -1, -1, -1 | |||
There was a problem hiding this comment.
These come from the user, could they not be int64?
Co-authored-by: Morgan <[email protected]>
With these changes,
intanduintare always represented in gnovm asint64anduint64whatever the underlying hardware architecture.There should be no change for 64 bits platforms. On other (unsupported) platforms,
intanduintwill be 64 bits instead of hardware size.Fixes #3288.